From 8306c0b66039c0301f884357b5257c338275655d Mon Sep 17 00:00:00 2001 From: Karel De Smet Date: Thu, 21 Dec 2023 08:31:29 +0100 Subject: [PATCH 1/2] refactor(all): change (references to) npm commands since yarn is the default package manager --- CONTRIBUTING.md | 8 ++++---- apps/mini-rx-angular-demo/README.md | 4 ++-- nx.json | 2 +- package.json | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 92e31882..8ef42aa1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,24 +7,24 @@ MiniRx Store uses [NX](https://nx.dev/) to manage several libraries and apps in Install the dependencies: ```shell -npm i +yarn install ``` ## Run Start the demo app with a watcher on the app and library code. ```shell -npm run dev +yarn dev ``` ## Test ```shell -npm run test:mini-rx-store:watch +yarn test:mini-rx-store:watch ``` ```shell -npm run test:mini-rx-store-ng:watch +yarn test:mini-rx-store-ng:watch ``` ## Questions and requests for support diff --git a/apps/mini-rx-angular-demo/README.md b/apps/mini-rx-angular-demo/README.md index b78a848c..0d4299af 100644 --- a/apps/mini-rx-angular-demo/README.md +++ b/apps/mini-rx-angular-demo/README.md @@ -20,11 +20,11 @@ This demo uses both the Redux API and the Feature Store API: ### Install dependencies -`npm install` +`yarn install` ### Run the demo -`npm run start:angular-demo` +`yarn start:angular-demo` ### NX diff --git a/nx.json b/nx.json index d84432c1..34c6e954 100644 --- a/nx.json +++ b/nx.json @@ -4,7 +4,7 @@ "defaultBase": "main" }, "cli": { - "packageManager": "npm" + "packageManager": "yarn" }, "tasksRunnerOptions": { "default": { diff --git a/package.json b/package.json index 9e15d5d1..5cd42683 100644 --- a/package.json +++ b/package.json @@ -17,9 +17,9 @@ "test:mini-rx-store-ng": "nx test mini-rx-store-ng", "test:mini-rx-store-ng:watch": "nx test mini-rx-store-ng --watch", "test:mini-rx-store-ng:coverage": "nx test mini-rx-store-ng --codeCoverage", - "deploy:docs": "npm run deploy --prefix docs", + "deploy:docs": "cd docs && yarn deploy && cd ..", "build:mini-rx-angular-demo:sourcemap": "nx build mini-rx-angular-demo --source-map", - "build:mini-rx-angular-demo:sourcemap:stats": "npm run build:mini-rx-angular-demo:sourcemap && source-map-explorer dist/apps/mini-rx-angular-demo/**/*.js", + "build:mini-rx-angular-demo:sourcemap:stats": "yarn build:mini-rx-angular-demo:sourcemap && source-map-explorer dist/apps/mini-rx-angular-demo/**/*.js", "prepare": "husky install" }, "private": true, From 7e03ff398ad9f7145599b2a923316ba489704ce5 Mon Sep 17 00:00:00 2001 From: Karel De Smet Date: Sat, 23 Dec 2023 12:56:21 +0100 Subject: [PATCH 2/2] Fix PR remark Co-authored-by: Florian Spier --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5cd42683..a6be3226 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "test:mini-rx-store-ng": "nx test mini-rx-store-ng", "test:mini-rx-store-ng:watch": "nx test mini-rx-store-ng --watch", "test:mini-rx-store-ng:coverage": "nx test mini-rx-store-ng --codeCoverage", - "deploy:docs": "cd docs && yarn deploy && cd ..", + "deploy:docs": "cd docs && yarn deploy", "build:mini-rx-angular-demo:sourcemap": "nx build mini-rx-angular-demo --source-map", "build:mini-rx-angular-demo:sourcemap:stats": "yarn build:mini-rx-angular-demo:sourcemap && source-map-explorer dist/apps/mini-rx-angular-demo/**/*.js", "prepare": "husky install"