Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config handling in server notifier "k8sbundle" #5514

Open
edwbuck opened this issue Sep 23, 2024 · 0 comments
Open

Improve config handling in server notifier "k8sbundle" #5514

edwbuck opened this issue Sep 23, 2024 · 0 comments
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@edwbuck
Copy link
Contributor

edwbuck commented Sep 23, 2024

The server "notifier" plugin "k8sbundle" has a combined set defaults / check configs / set items / create kube clients / etc.

This convolutes the configuration validation with logic that impacts the k8sbundle plugin, making configuration validation embedded within logic about how to use the configuration.

We need to separate out this logic such that we can have the buildConfig perform the validation and any default setting without immediately triggering its use. Then after all elements of the configuration is valid, we can create the kube clients / set non-configuration items / etc.

Discovered during work on #5303 and not included in that effort to avoid scope expansion.

@azdagron azdagron added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

2 participants