Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON output of CLI commands includes empty fields that should be omitted #5523

Open
amartinezfayo opened this issue Sep 27, 2024 · 0 comments
Open

JSON output of CLI commands includes empty fields that should be omitted #5523

amartinezfayo opened this issue Sep 27, 2024 · 0 comments
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@amartinezfayo
Copy link
Member

We use cliprinter.PrintProto to print Protobuf messages in JSON format.
Even if the Protobuf message specifies omitempty for a field, empty fields are still printed.
We should honor the omitempty property.
@amartinezfayo amartinezfayo added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Sep 27, 2024
@amartinezfayo amartinezfayo mentioned this issue Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amartinezfayo