From f0a0e99122c9ecfd79a40414758e313b2dfe8761 Mon Sep 17 00:00:00 2001 From: Daniel King Date: Wed, 15 Jan 2025 15:45:11 -0500 Subject: [PATCH] the min/max of an array without valid values is not defined (and definitely not null) --- vortex-array/src/array/primitive/stats.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vortex-array/src/array/primitive/stats.rs b/vortex-array/src/array/primitive/stats.rs index ea9feebc64..787c8609ab 100644 --- a/vortex-array/src/array/primitive/stats.rs +++ b/vortex-array/src/array/primitive/stats.rs @@ -403,7 +403,7 @@ mod test { let min: Option = arr.statistics().compute(Stat::Min); let max: Option = arr.statistics().compute(Stat::Max); let null_i32 = Scalar::null(DType::Primitive(PType::I32, Nullability::Nullable)); - assert_eq!(min, Some(null_i32.clone())); - assert_eq!(max, Some(null_i32)); + assert_eq!(min, None); + assert_eq!(max, None); } }