-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with php 7.2 or higher #28
Comments
My understanding is that Filelister uses mcrypt which isn't installed by default in php 7.2. Would be good to see Filelister updated as it works well otherwise. |
Don't think that's the reason, because mcrypt is installed here and it's not working with php 7.2. or higher. Also my opinion about mcrypt: There are a few important reasons why you do not want to use Mcrypt. The most important reason is that it is very easy to use unsafe cryptography functions, which does not benefit the security of your application. In addition, the libm crypt (which the PHP module uses) has not been in development for quite some time (last change in 2008!). Many bugs and safety risks are therefore not resolved. The vrandom generator is also very unreliable, which is very important for secure encryption. |
Apologies if I'm wrong - I was reading this thread: https://forums.modx.com/thread/104257/alternative-to-filelister-extra |
the question still remains if there's a good (save) alternative to work with Modx. |
In meanwhile there's a solution. It was indeed mcrypt. We replaced it with openSSL and everything works fine now! We will do a pull request. |
forked from splittingred/FileLister: https://github.com/ThijsFeryn/FileLister/tree/mcrypt_to_openssl |
I had this issue today and had to roll back to 7.1. Any chance this could be resolved. |
Use this solution: https://github.com/ThijsFeryn/FileLister/tree/mcrypt_to_openssl |
Will this solution upgrade FileLister by uploading as a separate package? Don't want to break this particular site if its meant to be applied a different way. |
It's not a seperate package, only a fix to the existing one. You have to copy it manually. |
Seems when I upgrade to 7.3 the extra breaks again... Nothing in error log to indicate issue it just simply doesn't work. This fix seemed to correct it 8bc241b |
Filelister stops working when I upgrade from php 7.1 to 7.2 or 7.3. Rolling back to 7.1 makes it work again.
The text was updated successfully, but these errors were encountered: