Add DroppedAttributeCount field to Otel/STEF schema #8
Comments
tigrannajaryan
added a commit
that referenced
this issue
Jan 24, 2025
Resolves #8 Otel/STEF schema changes: - Renamed "Attributes" multimap to "AttributesList". - Made "Attributes" a struct, containing 2 fields: a multimap of key/values and "DroppedAttributeCount". - Use the new "Attributes" struct in the "Resource", "Scope", "Span", etc structs. The schema changes reveal a serialization bug that I had to fix otherwise the tests were failing. The bug was in struct's Encode() function, where if a struct was encoded by reference the struct's modified bits were not correctly reset. The reset is now done recursively, which is necessary so that the next Encode() correctly picks up the field modifications. Also updated testdata files (because the schema is now different) and renamed the incorrect ".tefz" to ".stefz" extension.
tigrannajaryan
added a commit
that referenced
this issue
Jan 24, 2025
Resolves #8 Otel/STEF schema changes: - Renamed "Attributes" multimap to "AttributesList". - Made "Attributes" a struct, containing 2 fields: a multimap of key/values and "DroppedAttributeCount". - Use the new "Attributes" struct in the "Resource", "Scope", "Span", etc structs. The schema changes reveal a serialization bug that I had to fix otherwise the tests were failing. The bug was in struct's Encode() function, where if a struct was encoded by reference the struct's modified bits were not correctly reset. The reset is now done recursively, which is necessary so that the next Encode() correctly picks up the field modifications. Also updated testdata files (because the schema is now different) and renamed the incorrect ".tefz" to ".stefz" extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: