Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for customizable scaling ratios when using fp8 storage data type #86

Open
markkohdev opened this issue Sep 5, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@markkohdev
Copy link
Contributor

Currently when users of the python and java interfaces construct an index with the float8 storage datatype, we automatically use a scaling ratio of <1, 127> (python, java).

While this seems like a sane default, it effectively automatically reduces the precision of the value space (by a factor of 127/actual_range I think?). For some use cases, known/expected input dimensional value boundaries may be, for example, between -10.0 to 10.0, in which case we would get a higher precision quantization by using a scalefactor of <1, 10>.

It would be good if we could expose this parameter within the constructors of the bindings since they're already available in core.

@markkohdev markkohdev added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant