Get process PID, use it to send SIGTERM
#120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly destroying it.
mrdziuban
commented
Jan 29, 2025
| @@ -0,0 +1,48 @@ | |||
| package scala.sys.process | |||
There was a problem hiding this comment.
This has to be in the scala.sys.process package so it has access to Process.SimpleProcess, which is package private
Comment on lines
+20
to
+24
| val method = classOf[JProcess].getMethod("pid") | ||
| method.invoke(p) match { | ||
| case pid: java.lang.Long => pid | ||
| case pid => throw new RuntimeException(s"Expected process PID ($pid) to be a Long, but it was a ${pid.getClass.getName}") | ||
| } |
There was a problem hiding this comment.
If you're content with requiring everyone who develops sbt-revolver to use Java 9+ to do so, then this could be simplified to just p.pid, plus changing the catch block to handle NoSuchMethodError when users are on Java 8.
Otherwise, compiling this on Java 8 fails with an error
/Users/matt/sbt-revolver/src/main/scala/scala/sys/process/ProcessWithPid.scala:21:9: value pid is not a member of Process
p.pid
^
|
|
||
| private def killProcess(pid: Long): Unit = { | ||
| val exited = try { | ||
| JRuntime.getRuntime.exec(s"kill -15 $pid").waitFor(10, TimeUnit.SECONDS) |
There was a problem hiding this comment.
Open to suggestions on how long this waits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
Updates
AppProcessto hold onto aProcessWithPid, which is a new type defined in thescala.sys.processpackage. Given a standardProcess, theProcessWithPid.applymethod will do its best to get the PID of theProcess.Unfortunately the only way to do so is via reflection. We first have to reflect on the private
scala.sys.Process.SimpleProcess#pfield to get the underlyingjava.lang.Process. We then try to call thejava.lang.Process#pid()method, which exists in Java 9 and above. If that fails with aNoSuchMethodException, then we fall back to looking at the privatejava.lang.ProcessImpl#pidfield, which works in Java 8 and below.When a PID is discovered,
AppProcessuses it to send akill -15 <pid>to the process. It will wait 10 seconds for the process to exit before forcibly killing it withprocess.destroy().When we fail to discover a PID for any reason,
AppProcesswill just forcibly kill the process withprocess.destroy(), as it currently does.