ReactiveAfterConvertCallback not called after find operations

[micopiira]

To me it seems that ReactiveAfterConvertCallback is only called after entity save operations so I guess that at the moment we cannot modify entities after find operations using entity callbacks?

The method javadoc does state that Entity callback method invoked after a domain object is converted to be persisted. although the class level javadoc says Callback being invoked after a domain object is materialized from a CouchbaseDocument when reading results. these seem contradicting to me?

Maybe we need to implement more callbacks, possibly borrowing following callbacks from spring-data-mongodb?

The following callback methods are present in AbstractMappingEventListener:
onBeforeConvert: Called in MongoTemplate insert, insertList, and save operations before the object is converted to a Document by a MongoConverter.
onBeforeSave: Called in MongoTemplate insert, insertList, and save operations before inserting or saving the Document in the database.
onAfterSave: Called in MongoTemplate insert, insertList, and save operations after inserting or saving the Document in the database.
onAfterLoad: Called in MongoTemplate find, findAndRemove, findOne, and getCollection methods after the Document has been retrieved from the database.
onAfterConvert: Called in MongoTemplate find, findAndRemove, findOne, and getCollection methods after the Document has been retrieved from the database was converted to a POJO.

[mikereiche]

That sounds correct.

The callbacks a processed in CouchbaseTemplateSupport and ReactiveCouchbaseTemplateSupport.

https://github.com/spring-projects/spring-data-couchbase/blob/8404616bcc9474ca0ad4a97473db9bba7734d305/src/main/java/org/springframework/data/couchbase/core/CouchbaseTemplateSupport.java#L53:L68

https://github.com/spring-projects/spring-data-couchbase/blob/8404616bcc9474ca0ad4a97473db9bba7734d305/src/main/java/org/springframework/data/couchbase/core/ReactiveCouchbaseTemplateSupport.java#L56:L76

[micopiira]

@mikereiche ok, thanks for verifying my assumption.

To be able to use spring-data-couchbase I would need an easy way to modify entities after fetching them from the database, as currently there is no easy way to do this are you interested in implementing new callbacks for modifying entities after find operations and also possibly try to unify the callbacks with spring-data-mongodb?

I could also try to come up with a a PR for this if this is something of interest to you.

[mikereiche]

If you make a PR, I'll approve it. Just follow the pattern of the other callbacks.
Otherwise, you'll have to wait for me to do it :(