Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lettuce] Externalize ReadFrom configuration into property #3011

Closed
thiagoteichmann opened this issue Oct 8, 2024 · 4 comments
Closed

[Lettuce] Externalize ReadFrom configuration into property #3011

thiagoteichmann opened this issue Oct 8, 2024 · 4 comments
Labels
for: external-project For an external project and not something we can fix

Comments

@thiagoteichmann
Copy link

Currently using Lettuce but noticed that config properties lacks readFrom property and require code change to implement it, would be possible to externalize this in a property so we can override the default?

I currently have a redis sentinel totally configured by properties but I cannot configure read from property the same way.

Something like:

spring.redis.lettuce.config.read-from=REPLICA_PREFERRED

or 

spring.redis.config.read-from=REPLICA_PREFERRED
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 8, 2024
@mp911de
Copy link
Member

mp911de commented Oct 9, 2024

This is a Spring Boot issue, please file a ticket at https://github.com/spring-projects/spring-boot/issues.

@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
@mp911de mp911de added for: external-project For an external project and not something we can fix and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 9, 2024
@thiagoteichmann
Copy link
Author

thiagoteichmann commented Oct 9, 2024

Can you clarify why is not a spring data redis issue @mp911de ?

@mp911de
Copy link
Member

mp911de commented Oct 10, 2024

Because Spring Boot hosts the code to parse config properties and apply these to LettuceConnectionFactory and its config. See https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/redis/LettuceConnectionConfiguration.java

@thiagoteichmann
Copy link
Author

Thanks @mp911de !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix
Projects
None yet
Development

No branches or pull requests

3 participants