Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JettyClientHttpConnector triggers early cancellation #25849

Closed
rstoyanchev opened this issue Oct 1, 2020 · 0 comments
Closed

JettyClientHttpConnector triggers early cancellation #25849

rstoyanchev opened this issue Oct 1, 2020 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
5.2.10

Comments

@rstoyanchev
Copy link
Contributor

The connector uses Mono.from(Publisher) to obtain Jetty's ReactiveResponse. However it also cancels after the first item and is meant for use with a Publisher that can produce a sequence. We need to use Mono.fromDirect instead which does not cancel the upstream since in this case we only expect one item.

This will help with jetty-project/jetty-reactive-httpclient#22 so that the Jetty reactive client can abort the request in case of a cancel signal.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels Oct 1, 2020
@rstoyanchev rstoyanchev added this to the 5.2.10 milestone Oct 1, 2020
@rstoyanchev rstoyanchev self-assigned this Oct 1, 2020
@rstoyanchev rstoyanchev mentioned this issue Oct 2, 2020
Closed
rstoyanchev added a commit that referenced this issue Oct 2, 2020
@rstoyanchev
Minor refactoring in JettyClientHttpConnector
e44b08f 
See gh-25849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
5.2.10
Development

No branches or pull requests
1 participant
@rstoyanchev