Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning when GuiceModuleMetadata skips types due to visibility #28

Open
twicksell opened this issue Feb 22, 2018 · 0 comments
Open

Comments

@twicksell
Copy link

SpringModule filters types that are not visible. However, when this happens, Guice will attempt to construct the type on its own using just in time bindings. This usual leads to strange behaviors, such as singletons being instantiated by both Guice and Spring. Suggest at least logging a warning to make people aware that SpringModule will not be passing the binding to Guice when the type is not visible.

https://github.com/spring-projects/spring-guice/blob/master/src/main/java/org/springframework/guice/module/GuiceModuleMetadata.java#L141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant