Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonInteractiveShellSession trouble with screen clear #899

Open
jvalkeal opened this issue Oct 20, 2023 · 0 comments
Open

NonInteractiveShellSession trouble with screen clear #899

jvalkeal opened this issue Oct 20, 2023 · 0 comments
Labels
type/enhancement Is an enhancement request
Milestone
3.3.x

Comments

@jvalkeal
Copy link
Contributor

Time to time ShellTestIntegrationTests fail on testNonInteractive.

Trouble looks to be screen clear at

spring-shell/spring-shell-test-autoconfigure/src/test/java/org/springframework/shell/test/autoconfigure/ShellTestIntegrationTests.java

Line 109 in e2a7f34

NonInteractiveShellSession session2 = client.nonInterative("help", "help").run();

With a quick testing if you wait for screen to get cleared then test start to be reliable. Should we wait or fix something in a test emulation?
@jvalkeal jvalkeal added the type/enhancement Is an enhancement request label Oct 20, 2023
@jvalkeal jvalkeal added this to the 3.2.x milestone Oct 20, 2023
jvalkeal added a commit that referenced this issue Oct 21, 2023
@jvalkeal
Make ShellTestIntegrationTests more reliable
f3b8bf3 
- Temp workaround for letting tests pass
- Relates #899
@jvalkeal jvalkeal modified the milestones: 3.2.x, 3.3.x Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Is an enhancement request
Projects
None yet
Milestone
3.3.x
Development

No branches or pull requests
1 participant
@jvalkeal