Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log an exception in the KeyValueDelegate.getMountInfo(String path) #888

Open
v-ladynev opened this issue Dec 12, 2024 · 0 comments
Open
Labels
type: enhancement A general enhancement

Comments

@v-ladynev
Copy link

v-ladynev commented Dec 12, 2024

Log an exception after catching it
https://github.com/spring-projects/spring-vault/blob/main/spring-vault-core/src/main/java/org/springframework/vault/core/util/KeyValueDelegate.java#L121C2-L138C1

public MountInfo getMountInfo(String path) {

  MountInfo mountInfo = this.mountInfo.get(path);
  
  if (mountInfo == null) {
	  try {
  
		  mountInfo = doGetMountInfo(path);
	  }
	  catch (RuntimeException e) {
		  mountInfo = MountInfo.unavailable();
	  }
  
	  this.mountInfo.put(path, mountInfo);
  }
  return mountInfo;
}
@mp911de mp911de added the type: enhancement A general enhancement label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants