Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Springie vote count bug and funky startboxes. #46

Open
lumiera opened this issue Nov 19, 2015 · 2 comments
Open

Springie vote count bug and funky startboxes. #46

lumiera opened this issue Nov 19, 2015 · 2 comments
Labels

Comments

@lumiera
Copy link

lumiera commented Nov 19, 2015

Example: when player initiates startvote, his !yes vote is sent to server before before the startvote itself, so it's not counted, and to vote in own poll, one has to !yes again.

Another example is startbox editing: when the "horizonal split" button in pressed, these messages are shown in chat:

!clearbox
!addbox 0 0 100 25
!addbox 0 75 100 25

But what actually happens is that the server first receives the second one one, then !clearbox, then the last one, and the end result is only 1 box (defined by last message) present.

@db81
Copy link
Member

db81 commented Nov 19, 2015

The startvote thing is a Springie bug. It counts your vote, but erroneously reports that it's not counted right after that. If you press Start and don't click yes in the vote bar you should notice how the next person who says !y causes it to report two yes votes because it actually counts yours. I'll fix it in Springie eventually.

The boxes thing is probably a Springie bug too, it used to happen less often but seems to happen all the time now. This is not messages being sent out of order, messages in chat are displayed only after the server tells us it got them so the server gets them in order. Maybe it's SetRectangle response messages getting interleaved, need to investigate.

@db81 db81 closed this as completed Nov 19, 2015
@db81 db81 added the invalid label Nov 19, 2015
@db81 db81 reopened this Nov 19, 2015
@db81
Copy link
Member

db81 commented Nov 19, 2015

Reopened to serve as a reminder.

@db81 db81 changed the title Small bug: chat messages sometimes sent out of order Springie vote count bug and funky startboxes. Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants