Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the sudosh.c the termnew.c_lflag &= ~ECHO; seems useless #48

Open
wzis opened this issue Mar 30, 2024 · 1 comment
Open

In the sudosh.c the termnew.c_lflag &= ~ECHO; seems useless #48

wzis opened this issue Mar 30, 2024 · 1 comment

Comments

@wzis
Copy link

wzis commented Mar 30, 2024

In the rawmode function, the termnew is declared as a static struct termios, and without any other assignment for the c_lflag, its value remains 0, then why do you need the termnew.c_lflag &= ~ECHO ?

@squash
Copy link
Owner

squash commented May 22, 2024

I assume it is unnecessary leftover from the original author. Generally changes to the code since I took over was to implement new features and compatibility with newer systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants