Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.12 #583

Closed
dpordomingo opened this issue Mar 6, 2019 · 8 comments
Closed

Update to Go 1.12 #583

dpordomingo opened this issue Mar 6, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@dpordomingo
Copy link
Contributor

Since Go 1.12 is already there and both Go v1.11 and Go v1.12 supports Go Modules, we could also update .travis to v1.12.x and migrate from dep to go mod

@dpordomingo dpordomingo added the enhancement New feature or request label Mar 6, 2019
@smacker
Copy link
Contributor

smacker commented Mar 6, 2019

I would wait until we update go-conventions: https://github.com/src-d/guide/blob/master/engineering/conventions/go.md

@carlosms
Copy link
Contributor

carlosms commented Mar 8, 2019

I'm going to edit this issue to drop go mod and focus on go 1.12. We need to check travis, and the base docker images.

@carlosms carlosms changed the title Migrate to go mod and Go 1.12 Update to Go 1.12 Mar 8, 2019
@dpordomingo
Copy link
Contributor Author

but then we need another issue for go mod migration

@carlosms
Copy link
Contributor

But we can open it when the conventions guidelines are updated, don't you think?

@dpordomingo
Copy link
Contributor Author

I understood that it was a thing to do from a message from @smola on company Slack channels.

@se7entyse7en se7entyse7en self-assigned this Mar 13, 2019
@carlosms
Copy link
Contributor

Alright, then feel free to open a new issue for go mod. I guess we may have things to discuss (vendor vs no vendor for instance), while the go 1.12 is straightforward and should not depend on the go mod discussion.

@se7entyse7en se7entyse7en removed their assignment Mar 13, 2019
@smacker
Copy link
Contributor

smacker commented Mar 13, 2019

agree with Carlos on that. There is also a question about go mod tidy for example.

@dpordomingo
Copy link
Contributor Author

When I opened this issue I considered it would be like an umbrella for such different tasks and discussions... but ok, here is the new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants