Not all image attachments are embedded

[xygn]

Hi!

I am using emanote to host my markdown notes on the web. However, I've noticed that not all images linked within the file are embedded as an image. Rather they are displayed as an attachment, that on clicking leads you to the static/ source.

Here is an example note:
Source

*Funcio lassiea* / Loss of function - Virchow
![[Pasted image 20210624232124.png]]

In the webpage generated you can see it as:

I am unable to figure out what is causing this, as a few pictures are embedded and some aren't.

Is there anything I'm doing wrong?

Debug Log

Regards,
xygn

[srid]

From https://note.ema.srid.ca/demo/embed

Note that the embed wiki-link syntax must appear on a paragraph of its own, with no other text added next to it.

In code,

emanote/src/Emanote/Pandoc/Filter/Embed.hs

Line 31 in 8b85459

B.Para [B.Link (_id, _class, otherAttrs) _is (url, tit)] -> do

---

I see a number of images in that link inside list elements. Now list elements can contain paragraphs. So what if you make it like the following?

1. First element
2. Second element
    
    ![[Some Image]]
3. Third element

---

The reason for this constraint is mentioned in the footnote of the link further above,

This constraint is necessary to ensure that the HTML generated remains valid. Embedded content use block elements, which cannot be embedded inside inline nodes.

This applies to embedding notes (because that would create a <div> a block element), however embedding images involves creating a <img> element only, which is not a block element - so ideally we should allow that to happen - such that your notebook continues to work in its current state without requiring hacks like the above. I've filed #98 for that.

[srid]

Oh n/m. I see you included the source in your original post.

[srid]

Some of that is due to use of </br> and unnecessary empty line in the midst of lists, eg:

- *-itis* denotes inflammation </br>

- Types
	- Purulent infl. 
	- Serous infl.

[srid]

Filed a bug, #99

[xygn]

Some of that is due to use of </br> and unnecessary empty line in the midst of lists, eg:

- *-itis* denotes inflammation </br>

- Types
	- Purulent infl. 
	- Serous infl.

I was testing out if the empty lines or linebreaks would help, but even when it's just a normal list without unnecessary lines, it has the same result.

Filed a bug, #99

I have attached the generated HTML #99

[srid]

Is this now resolved for you, @xygn ?