Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

Add flag to inhibit movie creation in comp mode #290

Closed
WillB97 opened this issue Jan 22, 2021 · 2 comments · Fixed by #292
Closed

Add flag to inhibit movie creation in comp mode #290

WillB97 opened this issue Jan 22, 2021 · 2 comments · Fixed by #292

Comments

@WillB97
Copy link
Contributor

WillB97 commented Jan 22, 2021

Since we are looking at testing code by running short matches in CI and the videos created are discarded, it is unnecessary to record the movie in the first place.

Not doing a recording greatly increases the speed of the simulation and as such decreases the CI time. On an example CPU-only system a 5-second match is reduced from 2 minutes 18 seconds to 24 seconds.

This would most benefit #271 and PeterJCLaw/code-submitter#10

@PeterJCLaw
Copy link
Member

Since the quality of the recording is (IIRC) already controllable via the match file, maybe an option is to have quality 0 imply this?

@WillB97
Copy link
Contributor Author

WillB97 commented Jan 22, 2021

I was thinking simply having an environment variable like SR_COMP_NO_RECORD but using the match file also acheives a similar end.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants