Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-English-Definitions.txt #70

Open
chinese-words-separator opened this issue Dec 17, 2024 · 3 comments
Open

PD-English-Definitions.txt #70

chinese-words-separator opened this issue Dec 17, 2024 · 3 comments

Comments

@chinese-words-separator
Copy link

chinese-words-separator commented Dec 17, 2024

死循環		infinite loop
死循环		infinite loop
打盹		snooze
打盹		nap
@ssb22
Copy link
Owner

ssb22 commented Dec 17, 2024

Thanks, we already had 死循环 in the main data file for 6 years so I'm not sure why it needs to go into PD-English-Definitions as well—if the main entry is somehow not working somewhere, maybe we should check what's up with that? Can edit 打盹 though

ssb22 added a commit that referenced this issue Dec 17, 2024
@chinese-words-separator
Copy link
Author

I thought short definition should also exist in PD-English-Definitions even when it is already in the dictionary

@ssb22
Copy link
Owner

ssb22 commented Dec 17, 2024

Ah, that's not what I was thinking! In the README I tried to say (but maybe I didn't say it very well!) that the words in PD-English-Definitions are words that are not in the main CedPane file because they are also found in lots of other dictionaries (the main data is for words not typically found in "normal" dictionaries—it's dictionary additions and yes there might occasionally be a word that does also occur in one or two dictionaries but the idea is to avoid adding words that practically any dictionary should have: those go in PD-English-Definitions). So the two word sets are not supposed to overlap....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants