Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git link from buffer created by log-view-find-revision goes to page not found on Github #123

Open
jjnilton opened this issue May 14, 2024 · 0 comments
Labels

Comments

@jjnilton
Copy link

The README states that git-link works with VC revisions, but a URL generated from a buffer created by log-view-find-revision returns 404 error on Github.

Reproduce steps:

  1. C-x v l in a git tracked file/buffer
  2. f on a commit
  3. A buffer named FileName.php.~adcfbddbc26784c5f6dbd9e1860e4afee58f013a~ is generated
  4. M-x git-link

Result:

https://github.com/[org]/[repo]/blob/bugfix%2Fab%2318867/src/[redacted]/[redacted]/[redacted]/FileName.php.~adcfbddbc26784c5f6dbd9e1860e4afee58f013a~#L1

Visiting the generate URL goes to a 404 - page not found on Github.

Expected:

https://github.com/[org]/[repo]/blob/af469d650ba1a823f9a8b390399d7f8dd9956e76/src/[redacted]/[redacted]/[redacted]/FileName.php#L1

A working URL like the ones from git-timemachine and magit generated buffers.

System version:
GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2023-02-23, modified by Debian
Description: Debian GNU/Linux 11 (bullseye)

@sshaw sshaw added the bug label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants