Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient integration is breaking doomemacs setup #129

Open
vlnn opened this issue Oct 22, 2024 · 6 comments
Open

Transient integration is breaking doomemacs setup #129

vlnn opened this issue Oct 22, 2024 · 6 comments

Comments

@vlnn
Copy link

vlnn commented Oct 22, 2024

After upgrading to latest version of git-link doom emacs starts to fail during the start.

Warning (initialization): An error occurred while booting Doom Emacs:

Symbol's function definition is void: transient-prefix
To ensure normal operation, you should investigate and remove the
cause of the error in your Doom config files. Start Emacs with
the '--debug-init' option to view a complete error backtrace.
Error (doom-after-init-hook): Error running hook "doom-display-benchmark-h"
because: (wrong-type-argument hash-table-p nil)

It looks like the issue below somehow got to the git-link, as after disabling it in the packages emacs is accessible again.

magit/transient#254

@jplindstrom
Copy link

One more data point: Happens with use-package with straight too.

@dpassen
Copy link

dpassen commented Oct 22, 2024

use-package with elpaca also fails to install the latest.

@sshaw
Copy link
Owner

sshaw commented Oct 22, 2024

@blahgeek ideas on how to fix?

Reverted the commits for now. It seems no ones uses MELPA stable?

@sshaw
Copy link
Owner

sshaw commented Oct 22, 2024

Reverted the commits for now. It seems no ones uses MELPA stable?

Well other options too.

How are you pulling in this package @dpassen @jplindstrom @vlnn @vespesa

@necaris
Copy link

necaris commented Oct 22, 2024

Note: using the version without the Transient integration seems to work for me -- using Doom Emacs, the following line in my packages.el pins the commit:

  (package! git-link :pin "fd33c3f7692bdf4b039afaa88cf07580429043ad")

It seems that for compatibility with Emacs 29.x you need a slightly different autoload declaration for Transient?

@vlnn
Copy link
Author

vlnn commented Oct 23, 2024

Revert (and moving transient functionality to another repo) helped in my case, so pinning to previous commits should not be needed anymore. Thanks @sshaw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants