Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to commit changing the current line #6

Open
dolzenko opened this issue Oct 8, 2014 · 4 comments
Open

Jump to commit changing the current line #6

dolzenko opened this issue Oct 8, 2014 · 4 comments
Milestone

Comments

@dolzenko
Copy link
Contributor

dolzenko commented Oct 8, 2014

Something like this would be golden for code review, I assume just needs some git blame + git-commit-link plumbing?

@sshaw
Copy link
Owner

sshaw commented Oct 9, 2014

Good idea.

My initial thoughts are that git-link-commit + a git blame mode (magit-blame for example) would do it, but that is an extra step and magit-blame doesn't allow the point over commit hashes...

Nevertheless I think the link alists should probably be consolidated first.

@sshaw
Copy link
Owner

sshaw commented Oct 9, 2014

Suggestions for the function's name? I'm thinking git-link-blame. Though at some point may be good to be able use a prefix + git-link for everything.

@dolzenko
Copy link
Contributor Author

Yeah, not being able to point to commit hash in magit blame drives me crazy too, should it be git-link-blame-line? I would expect git-link-blame to take me just to blame view for the file.

@sshaw
Copy link
Owner

sshaw commented Oct 13, 2014

Maybe, but I think the functionality implies that it's a line number. Why would a given point send one to a blame for the whole file? Line number is more dwim and is in line with the library's other functions...

@sshaw sshaw added this to the v1.0 milestone Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants