Skip to content

Commit

Permalink
Fix expected error; Bring back commented tests
Browse files Browse the repository at this point in the history
  • Loading branch information
MatheusFranco99 committed Jan 10, 2024
1 parent 1c3ace2 commit e67c4b5
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 39 deletions.
84 changes: 47 additions & 37 deletions types/spectest/all_tests.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@ package spectest
import (
"testing"

"github.com/bloxapp/ssv-spec/types/spectest/tests/beacon"
"github.com/bloxapp/ssv-spec/types/spectest/tests/consensusdata"
consensusdataproposer "github.com/bloxapp/ssv-spec/types/spectest/tests/consensusdata/proposer"
"github.com/bloxapp/ssv-spec/types/spectest/tests/ssz"

"github.com/bloxapp/ssv-spec/types/spectest/tests/encryption"
"github.com/bloxapp/ssv-spec/types/spectest/tests/partialsigmessage"
"github.com/bloxapp/ssv-spec/types/spectest/tests/share"
"github.com/bloxapp/ssv-spec/types/spectest/tests/ssvmsg"

"github.com/bloxapp/ssv-spec/types/spectest/tests/signedssvmsg"
)

Expand All @@ -12,50 +22,50 @@ type SpecTest interface {
}

var AllTests = []SpecTest{
// ssvmsg.Encoding(),
ssvmsg.Encoding(),

// partialsigmessage.Encoding(),
partialsigmessage.Encoding(),

// share.Encoding(),
// //share.HasQuorum(),
// //share.QuorumWithDuplicate(),
// //share.HasQuorum3f1(),
// //share.NoQuorum(),
// //share.NoQuorumDuplicate(),
// //share.HasPartialQuorum(),
// //share.PartialQuorumWithDuplicate(),
// //share.HasPartialQuorum2f1(),
// //share.NoPartialQuorum(),
// //share.NoPartialQuorumDuplicate(),
share.Encoding(),
//share.HasQuorum(),
//share.QuorumWithDuplicate(),
//share.HasQuorum3f1(),
//share.NoQuorum(),
//share.NoQuorumDuplicate(),
//share.HasPartialQuorum(),
//share.PartialQuorumWithDuplicate(),
//share.HasPartialQuorum2f1(),
//share.NoPartialQuorum(),
//share.NoPartialQuorumDuplicate(),

// encryption.SimpleEncrypt(),
// encryption.EncryptBLSSK(),
encryption.SimpleEncrypt(),
encryption.EncryptBLSSK(),

// // TODO: consider removing tests below
// consensusdata.Encoding(),
// //consensusdata.DutyNil(),
// //consensusdata.ValidAttester(),
// //consensusdata.NoAttestationData(),
// //consensusdata.ValidAggregator(),
// //consensusdata.NoAggregatorData(),
// //consensusdata.ValidProposer(),
// //consensusdata.ValidBlindedProposer(),
// //consensusdata.NilBlock(),
// //consensusdata.BlockAndBlindedBlock(),
// //consensusdata.ValidSyncCommitteeAggregator(),
// //consensusdata.EmptySyncCommitteeAggregator(),
// // TODO: add new consensusdata tests
// TODO: consider removing tests below
consensusdata.Encoding(),
//consensusdata.DutyNil(),
//consensusdata.ValidAttester(),
//consensusdata.NoAttestationData(),
//consensusdata.ValidAggregator(),
//consensusdata.NoAggregatorData(),
//consensusdata.ValidProposer(),
//consensusdata.ValidBlindedProposer(),
//consensusdata.NilBlock(),
//consensusdata.BlockAndBlindedBlock(),
//consensusdata.ValidSyncCommitteeAggregator(),
//consensusdata.EmptySyncCommitteeAggregator(),
// TODO: add new consensusdata tests

// consensusdataproposer.VersionedBlockValidation(),
// consensusdataproposer.VersionedBlindedBlockValidation(),
// consensusdataproposer.VersionedBlockUnknownVersion(),
// consensusdataproposer.VersionedBlindedBlockUnknownVersion(),
// consensusdataproposer.VersionedBlockConsensusDataNil(),
// consensusdataproposer.VersionedBlindedBlockConsensusDataNil(),
consensusdataproposer.VersionedBlockValidation(),
consensusdataproposer.VersionedBlindedBlockValidation(),
consensusdataproposer.VersionedBlockUnknownVersion(),
consensusdataproposer.VersionedBlindedBlockUnknownVersion(),
consensusdataproposer.VersionedBlockConsensusDataNil(),
consensusdataproposer.VersionedBlindedBlockConsensusDataNil(),

// ssz.SSZWithdrawalsMarshaling(),
ssz.SSZWithdrawalsMarshaling(),

// beacon.DepositData(),
beacon.DepositData(),

signedssvmsg.Encoding(),
signedssvmsg.Valid(),
Expand Down
2 changes: 1 addition & 1 deletion types/spectest/generate/tests.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion types/spectest/tests/signedssvmsg/wrong_data.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ func WrongData() *SignedSSVMessageTest {
Data: []byte{1, 2, 3, 4},
},
},
ExpectedError: "incorrect size",
ExpectedError: "could not decode SSVMessage from data in SignedSSVMessage: incorrect size",
}
}

0 comments on commit e67c4b5

Please sign in to comment.