-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix json generation #522
fix json generation #522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should use filepath
tools
I think they are not system dependent..
I think currently it is possible to work on spec tests from Windows (never tried it)
I don't see anything that will not work on windows except permissions. But I am unsure how to fix that |
@MatusKysel, you've made the change for the |
@MatusKysel Anyhow |
@GalRogozinski check it one more time, I am actually fixing it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this isn't on you but can you change permissions to everytime we write file to (0664). This should solve issues when we run generate several times
39c3a71
to
b83bb39
Compare
After recent change in spec, we need to run
go generate
to get tests.json file used for testing in ssv. But because ofruntime.Caller(0)
generating json outside the repo is impossible. Whit this proposed change we can run it in any directory, where the binary used for generating code is located