all: avoid passing logger to methods

[nkryuchkov]

as per title

[y0sher]

gj, we should do this code-wide :)

[nkryuchkov]

@y0sher I did it code-wide, although I might have missed something. Anyway, we'll be able to fix leftovers if we find them. Please review it again

[codecov]

Codecov Report

Attention: Patch coverage is 45.97701% with 188 lines in your changes missing coverage. Please review.

Project coverage is 47.5%. Comparing base (c55c696) to head (3ee7692).

Files with missing lines	Patch %	Lines
network/p2p/p2p.go	23.0%	28 Missing and 2 partials ⚠️
operator/node.go	0.0%	29 Missing ⚠️
utils/boot_node/node.go	0.0%	18 Missing ⚠️
network/p2p/p2p_pubsub.go	23.5%	11 Missing and 2 partials ⚠️
cli/operator/node.go	0.0%	9 Missing ⚠️
network/peers/conn_manager.go	18.1%	9 Missing ⚠️
network/topics/controller.go	52.6%	9 Missing ⚠️
operator/duties/scheduler_mock.go	0.0%	8 Missing ⚠️
network/peers/connections/conn_handler.go	0.0%	6 Missing ⚠️
exporter/api/server.go	80.0%	4 Missing and 1 partial ⚠️
... and 22 more

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[oleg-ssvlabs]

Awesome, these are certainly great changes!
An alternative approach could be having a separate logger package that encapsulates Zap and is loaded as a package (rather than being injected through a constructor or function/method).
Something like this:

package logger

import "go.uber.org/zap"

var logger = zap.L()

func Info(msg string, fields ...zap.Field) {
	logger.Info(msg, fields...)
}

And the usage:

package main

import "github.com/ssvlabs/utils/logger"

func main() {
	logger.Info("Hello, world!")
}

However, if we want to have named loggers at the object level or loggers with additional properties applicable to all log records, we would likely still need to inject it through a constructor.

[iurii-ssv]

Good stuff!