Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -nodeport discovery configmap #765

Open
nightkr opened this issue Oct 7, 2024 · 3 comments
Open

Remove -nodeport discovery configmap #765

nightkr opened this issue Oct 7, 2024 · 3 comments
Assignees
@nightkr
Labels
scheduled-for/25.7.0

Comments

@nightkr
Copy link
Member

nightkr commented Oct 7, 2024 •
edited
Loading

It's redundant now that #443 (24.11) brings first-class NodePort support. The primary discovery CM will now automatically adapt to the selected ListenerClass.

Deprecation schedule:

Users are encouraged to replace all uses with the primary discovery CM after upgrading to 24.11.
@nightkr nightkr moved this to Awaiting Deprecation in Stackable Deprecation Schedule Nov 1, 2024
@nightkr nightkr self-assigned this Jan 22, 2025
@nightkr nightkr moved this to Development: In Progress in Stackable Engineering Jan 22, 2025
@nightkr
Copy link
Member Author

nightkr commented Jan 22, 2025

Looks like we never actually deprecated this properly back in 24.11. I would propose rescheduling it for deprecation in 25.3 and removal in 25.3+1.

@lfrancke
Copy link
Member

Makes sense. Thanks for catching it. I agree with the proposal.

nightkr added a commit that referenced this issue Jan 22, 2025
@nightkr
Document -nodeport discovery as deprecated
91fecd3 
See #765
@nightkr nightkr mentioned this issue Jan 22, 2025
Merged
@nightkr nightkr moved this from Awaiting Deprecation to Deprecated in Stackable Deprecation Schedule Jan 23, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2025
@nightkr
Deprecate -nodeport discovery ConfigMap (#813)
26b1220 
* Document -nodeport discovery as deprecated

See #765

* Add deprecation warning to -nodeport discovery configmaps

* Changelog

* Fix import warning
@nightkr nightkr moved this from Development: In Progress to Development: Done in Stackable Engineering Jan 24, 2025
@nightkr
Copy link
Member Author

nightkr commented Jan 24, 2025

Marking this as "done" since #813 is merged, but we shouldn't close it before it's removed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nightkr nightkr

Labels
scheduled-for/25.7.0
Projects
Stackable Deprecation Schedule
Status: Deprecated
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lfrancke @nightkr @sbernauer