Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Hamburger "menu" missing some properties and states of a disclosure control #1044

Open
3 tasks
jason-me opened this issue Feb 9, 2025 · 0 comments

Comments

@jason-me
Copy link
Contributor

jason-me commented Feb 9, 2025

Issue

The Hamburger Menu does not follow the established design pattern for a disclosure control

Expected Behavior

  • WCAG 2.2 AA 4.1.2 Name, Role, Value requires that programmatically determined states and properties are communicated to screen reader users.
  • WAI - ARIA APG Disclosure Show/Hide Pattern requires that when the content is visible, the element with role button has aria-expanded set to true. When the content area is hidden, it is set to false.
    Optionally, the element with role button has a value specified for aria-controls that refers to the element that contains all the content that is shown or hidden.
  • Screen reader users expect to hear this information when interacting with disclosure buttons to determine the current state of the control

Acceptance Criteria

  • Add an aria-expanded attribute on the HamburgerButton which returns true when expanded and false when not expanded
  • Optionally add an aria-controls attribute to the HamburgerButton which refernces the id of the container for the exposed controls
  • Test with a screen reader JAWS, VoiceOver, NVDA, Orca, Talkback, etc. - ensure the expanded state is announced

Linked to tracking issue: #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant