You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is something I noticed while reviewing ppc_dens_overlay(). The density defaults were hard-coded for ppc_dens_overlay() but not for these similar functions.
mcmc_areas<-function(...,
bw=NULL,
adjust=NULL,
kernel=NULL,
n_dens=NULL) {}
mcmc_areas_data<-function(...,
bw=NULL,
adjust=NULL,
kernel=NULL,
n_dens=NULL) {}
mcmc_areas_ridges<-function(...,
bw=NULL,
adjust=NULL,
kernel=NULL,
n_dens=NULL){}
mcmc_areas_ridges_data<-function(...,
bw=NULL,
adjust=NULL,
kernel=NULL,
n_dens=NULL) {}
# this function does all the density calculations for the four above functionscompute_interval_density<-function(x, interval_width=1, n_dens=1024,
bw=NULL, adjust=NULL, kernel=NULL) {
n_dens<-n_dens %||% 1024...
}
We should make this more consistent and update the @template args-density-controls boilerplate file.
The text was updated successfully, but these errors were encountered:
This is something I noticed while reviewing
ppc_dens_overlay()
. The density defaults were hard-coded forppc_dens_overlay()
but not for these similar functions.We should make this more consistent and update the
@template args-density-controls
boilerplate file.The text was updated successfully, but these errors were encountered: