Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we drop the vertical line in mcmc_areas() and mcmc_areas_ridges()? #195

Open
jgabry opened this issue May 20, 2019 · 2 comments
Open
Labels

Comments

@jgabry
Copy link
Member

jgabry commented May 20, 2019

I'm starting to think that maybe we shouldn't be hardcoding the vertical line at zero at all. Users don't have the option to remove and it would be super easy for them to add a vertical afterwards if they want it. We could consider suggesting users add + vline_0() (or + geom_vline(xintercept=0) directly) after making the plot if they want the vertical line.

I'm not saying we should definitely change this, just thinking out loud. Of course if someone wants the plot without the line they do already have the option of getting the data from mcmc_*_data() and making it themselves.

@jgabry
Copy link
Member Author

jgabry commented May 20, 2019

I suppose another option is to have an argument to toggle it.

@avehtari
Copy link
Contributor

Makes sense either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants