Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiled models are saved using ascii characters only #1911

Closed
RawEnchilada opened this issue Dec 9, 2024 · 2 comments · May be fixed by #1912
Closed

Compiled models are saved using ascii characters only #1911

RawEnchilada opened this issue Dec 9, 2024 · 2 comments · May be fixed by #1912

Comments

@RawEnchilada
Copy link

RawEnchilada commented Dec 9, 2024 •
edited
Loading

The compiled prompts are converted into unicode special characters when saved.

The simple fix is to pass the optional ensure_ascii parameter to json.dumps
@RawEnchilada RawEnchilada mentioned this issue Dec 9, 2024
Open
@okhat
Copy link
Collaborator

okhat commented Dec 16, 2024

Just so I understand. Do you want to allow ensure_ascii=False? Should we just make it False by default?

@okhat
Copy link
Collaborator

okhat commented Dec 16, 2024

I'm closing this to avoid discussing the same thing in two places. Will discuss in the PR.

@okhat okhat closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow non ascii characters in compiled prompts RawEnchilada/dspy
2 participants
@okhat @RawEnchilada