Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted overriding of default coloring when the color has not been changed #32

Open
Pheotis opened this issue Jun 4, 2024 · 2 comments
Labels
issue A problem that – while inconvenient – does not impede core functionality

Comments

@Pheotis
Copy link
Contributor

Pheotis commented Jun 4, 2024

Attempting to set default colours still results in an ugly mess.

sgi config DEFAULT_SIGN_COLOR blue
Produces this mess (shown beside a blue dye for comparison)
image

What is even happening here?
This isn't something that needs to be fixed before the alpha, but it does eventually need to be fixed.

@Pheotis Pheotis added the issue A problem that – while inconvenient – does not impede core functionality label Jun 4, 2024
@Thorinwasher
Copy link
Contributor

Why is this in SGC?

Do you mean we should fix this in SGC or something?

@Thorinwasher
Copy link
Contributor

Thorinwasher commented Jun 11, 2024

With further research, this is an issue with SGM enforcing the dyecolor of the sign to be the actuall color of the sign.

Currently the default dyecolor applied to the sign is aproximated to be the one that is closest to our customized color, in this case for BLUE we choose #8e9ada, which really is closer in the color spectrum to the LIGHT_GRAY dye color.

From what I rememeber, SGM implements a coloring feature very similar to core, do we really need to have it?

Anyhow the current implementation does not seem to respect the default coloring setting in core. I think the colors are supposed to only override the default coloring whenever the user has actually colored the sign.

@Thorinwasher Thorinwasher transferred this issue from stargate-rewritten/Stargate-Customizations Jun 11, 2024
@Thorinwasher Thorinwasher changed the title Portal default colours are still ugly af. Unwanted overriding of default coloring when the color has not been changed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue A problem that – while inconvenient – does not impede core functionality
Projects
None yet
Development

No branches or pull requests

2 participants