Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_10 #6647

Open
piotmag769 opened this issue Nov 13, 2024 · 0 comments · May be fixed by #6699
Open

Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_10 #6647

piotmag769 opened this issue Nov 13, 2024 · 0 comments · May be fixed by #6699
Assignees
@piotmag769
Labels
bug Something isn't working ide This issue refers to CairoLS or editor extensions

Comments

@piotmag769
Copy link
Collaborator

Reproduction: set snforge_std = "0.33.0" as dependency and then type

#[test]
fn test() {
   snforge_std::declare("Empty").unwrap().contract_class().class_hash;
}
@piotmag769 piotmag769 added bug Something isn't working ide This issue refers to CairoLS or editor extensions labels Nov 13, 2024
@piotmag769 piotmag769 moved this to Triage in CairoLS Nov 13, 2024
@mkaput mkaput mentioned this issue Nov 14, 2024
Open
2 tasks
@Arcticae Arcticae moved this from Triage to Todo in CairoLS Nov 14, 2024
@piotmag769 piotmag769 moved this from Todo to In Progress in CairoLS Nov 19, 2024
@piotmag769 piotmag769 changed the title Missing trait code action doesn't work for dependency other than corelib Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_11 Nov 19, 2024
@piotmag769 piotmag769 changed the title Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_11 Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_10 Nov 19, 2024
@piotmag769 piotmag769 changed the title Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_10 Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_10 Nov 19, 2024
@piotmag769 piotmag769 changed the title Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_10 Missing trait code action doesn't work for traits without pub but from package with edition <= 2023_10 Nov 19, 2024
@piotmag769 piotmag769 linked a pull request Nov 19, 2024 that will close this issue
LS: Fix missing trait code action for traits without pub but from crate with edition <= 2023_10 #6699
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotmag769 piotmag769

Labels
bug Something isn't working ide This issue refers to CairoLS or editor extensions
Projects
CairoLS
Status: In Progress
Milestone
No milestone
1 participant
@piotmag769