Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionVersion should be an u8 #199

Open
tdelabro opened this issue Mar 21, 2024 · 2 comments
Open

TransactionVersion should be an u8 #199

tdelabro opened this issue Mar 21, 2024 · 2 comments

Comments

@tdelabro
Copy link
Contributor

pub struct TransactionVersion(pub StarkFelt);

The transaction version is not part of the starknet state. It is occasionally used as an Felt to compute some hash, but most of the time it is manipulated by the sequencer in a non-provable context, so there is no reason for it to have Felt being its default representation.
It should be an u8, and a Felt can easily be constructed from an u8 when needed.

@raizo07
Copy link

raizo07 commented Mar 22, 2024

Hello @tdelabro can this be assigned to me to work on?

@tdelabro
Copy link
Contributor Author

Thanks for your enthusiasm @raizo07 sadly I have to give you the same answer as for this one: starkware-libs/blockifier#1703 (comment)

Let's wait for the repo maintainers to give an opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants