Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIWE to sign in via Wallet Connect #14996

Open
6 tasks
Tracked by #16312
clauxx opened this issue May 31, 2024 · 3 comments · May be fixed by #16550
Open
6 tasks
Tracked by #16312

Add SIWE to sign in via Wallet Connect #14996

clauxx opened this issue May 31, 2024 · 3 comments · May be fixed by #16550
Labels
dapp-interactions E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature wallet-team
Milestone
2.32.0 Beta

Comments

@clauxx
Copy link
Member

clauxx commented May 31, 2024 •
edited
Loading

Description

As a user, I want to be able to sign in with a dapp in one interaction, so that the dapp onboarding is more user friendly.

Aside from the usual session establishment, we should also support authentication with SIWE (see wallet connect docs).

Design link

Acceptance Criteria

  • the user can see a connection screen when SIWE auth is triggered from the dapp
  • the user can see the message from the dapp (no url highlights)
  • the user can expand/collapse the message from the dapp on press
  • the user can see and change the account used to sign in
  • the user can use biometrics/password to sign the message from the dapp
  • the user can log in with the dapp after the interaction is done
@clauxx clauxx added dapp-interactions E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature labels May 31, 2024
@clauxx clauxx added this to the 2.30.0 Beta milestone May 31, 2024
@clauxx clauxx moved this to Next Iteration in Status Desktop/Mobile Board Jun 5, 2024
@alexjba alexjba modified the milestones: 2.30.0 Beta, 2.31.0 Beta Aug 8, 2024
@alexjba
Copy link
Contributor

alexjba commented Aug 8, 2024

Moving to 2.31

@alexjba
Copy link
Contributor

alexjba commented Aug 8, 2024

@clauxx Do you forsee any issues with the SIWE dapps if we don't support it yet? Looking at the WC docs I see we should be ok if personal_sign is supported.

Configuring your Web3Modal client with AuthRequestParams will prioritize authentication requests over regular session proposals. If the wallet supports One-Click Auth, the session will be created and the user will automatically authenticate without needing to send another SIWE request over personal_sign. If the wallet does not support One-Click Auth, it will fall back to the session proposal. In this case, to authenticate the user, you can send another session request to prove address ownership.

@clauxx
Copy link
Member Author

clauxx commented Aug 8, 2024 •
edited
Loading

@alwx Yeah I think we should be fine. One improvement from adding it would be fixing the edge case where:

  1. dapp prompts user to connect
  2. user approves connection
  3. dapp sends personal_sign SIWE request
  4. user rejects
  5. dapp is shown as connected (but the dapp is not connected)

For this though dapps would have to explicitly add support to walletconnect's "one click auth" and from what we tested, none of the popular ones have this apart from the testing dapps.

@alexjba alexjba mentioned this issue Aug 14, 2024
Open
@alexjba alexjba mentioned this issue Sep 11, 2024
Open
23 tasks
@alaibe alaibe modified the milestones: 2.31.0 Beta, 2.32.0 Beta Oct 6, 2024
@alexjba alexjba linked a pull request Oct 18, 2024 that will close this issue
14996 add siwe to sign in via wallet connect #16550
Open
2 tasks
@alexjba alexjba linked a pull request Oct 18, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dapp-interactions E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature wallet-team
Projects
Status Desktop/Mobile Board
Status: No status
Milestone
2.32.0 Beta
Development

Successfully merging a pull request may close this issue.

14996 add siwe to sign in via wallet connect status-im/status-desktop
4 participants
@iurimatias @alaibe @clauxx @alexjba