Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Token Selector #16702

Open
Tracked by #16696
Khushboo-dev-cpp opened this issue Nov 4, 2024 · 2 comments · May be fixed by #16733
Open
Tracked by #16696

Adapt Token Selector #16702

Khushboo-dev-cpp opened this issue Nov 4, 2024 · 2 comments · May be fixed by #16733
Assignees
@Khushboo-dev-cpp
Labels
wallet-team

Comments

@Khushboo-dev-cpp
Copy link
Contributor

Khushboo-dev-cpp commented Nov 4, 2024 •
edited
Loading

This task is created to adapt the TokenSelector Component to be able to support the new Simple Send Modal

Design:
https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25229-108897&t=Ech2sOd4zCGhGFzC-4
https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25232-114042&t=x7Ukt7ixxp7Ji84n-4

The difference in current implementation and new designs is that we only want to show the balances on the networks selected in the modal. Currently the TokenSelector shows all the balances in balances model

Changes expected TBD in this task -

  1. No collectibles state
  2. Only 5 items and 6th item half when shown
  3. Only balance on selected network is shown (a filter is already present in adaptor, no changes needed)
  4. 0 balance on selected chain is not shown (Logic already present in adaptor, no changes needed))
  5. Token list items are inset 4px with 4px padding between each list item.
  6. Top search result in typeahead adopts hover state so user can easily press Enter (or click) to select.
  7. Token icon in header increased in size slightly (21px -> 24px). Collectibles more visible at this size.
  8. Hovered and selected highlight colours
@Khushboo-dev-cpp Khushboo-dev-cpp mentioned this issue Nov 4, 2024
Open
20 tasks
@Khushboo-dev-cpp Khushboo-dev-cpp changed the title Token Selector Adapt Token Selector Nov 4, 2024
@micieslak
Copy link
Member

Probably the whole chance may be limited to the adaptor where additional filtering is needed now to have only one network there.

Should we present tokens with 0 balance on a given network as well?

@Khushboo-dev-cpp
Copy link
Contributor Author

Probably the whole chance may be limited to the adaptor where additional filtering is needed now to have only one network there.

Should we present tokens with 0 balance on a given network as well?

seems like there is provision to do it already. if thats the case, I'll simply close this task. As per design tokens with 0 balance on a selected network will not be shown in the token selector list. https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25126-90209&t=aU54CRDOkx31jmCm-4

@Khushboo-dev-cpp Khushboo-dev-cpp self-assigned this Nov 7, 2024
Khushboo-dev-cpp added a commit that referenced this issue Nov 8, 2024
@Khushboo-dev-cpp
feat(@desktop/wallet): Adapt Token Selector
9e7dad7 
fixes #16702
@Khushboo-dev-cpp Khushboo-dev-cpp linked a pull request Nov 8, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khushboo-dev-cpp Khushboo-dev-cpp

Labels
wallet-team
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(@desktop/wallet): Adapt Token Selector status-im/status-desktop
3 participants
@iurimatias @micieslak @Khushboo-dev-cpp