Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max button in swap #17198

Open
alaibe opened this issue Feb 4, 2025 · 1 comment · May be fixed by #17230
Open

Max button in swap #17198

alaibe opened this issue Feb 4, 2025 · 1 comment · May be fixed by #17230
Assignees
@Khushboo-dev-cpp
Labels
wallet-team
Milestone
2.33.0 Beta

Comments

@alaibe
Copy link
Collaborator

alaibe commented Feb 4, 2025

Description

In case of eth swap: the max button does current value - max fee

In case of an erc20: the max button simply apply the balance of the erc20
@alaibe alaibe added this to the 2.33.0 Beta milestone Feb 4, 2025
@Khushboo-dev-cpp Khushboo-dev-cpp self-assigned this Feb 4, 2025
Khushboo-dev-cpp added a commit that referenced this issue Feb 5, 2025
@Khushboo-dev-cpp
feat(@desktop/wallet): Swap changes needed for 2.33
7220a49 
1. Max button functionality
2. Hardcode swap modal to swap USDT <-> WETH
3. Fixing some issues found
4. Not limiting number entered by user

fixes #17198, #17200
@Khushboo-dev-cpp Khushboo-dev-cpp linked a pull request Feb 5, 2025 that will close this issue
Open
2 tasks
Khushboo-dev-cpp added a commit that referenced this issue Feb 6, 2025
@Khushboo-dev-cpp
feat(@desktop/wallet): Swap changes needed for 0.33
1f6a46a 
1. Max button functionality
2. Hardcode swap modal to swap USDT <-> WETH
3. Fixing some issues found
4. Not limiting number entered by user

fixes #17198, #17200
Khushboo-dev-cpp added a commit that referenced this issue Feb 6, 2025
@Khushboo-dev-cpp
feat(@desktop/wallet): Swap changes needed for -1.33
8d5dbaf 
1. Max button functionality
2. Hardcode swap modal to swap USDT <-> WETH
3. Fixing some issues found
4. Not limiting number entered by user

fixes #17198, #17200
Khushboo-dev-cpp added a commit that referenced this issue Feb 6, 2025
@Khushboo-dev-cpp
feat(@desktop/wallet): Swap changes needed for -2.33
637bbb7 
1. Max button functionality
2. Hardcode swap modal to swap USDT <-> WETH
3. Fixing some issues found
4. Not limiting number entered by user

fixes #17198, #17200
Khushboo-dev-cpp added a commit that referenced this issue Feb 6, 2025
@Khushboo-dev-cpp
feat(@desktop/wallet): Swap changes needed for -2.33
8ec3b2e 
1. Max button functionality
2. Hardcode swap modal to swap USDT <-> WETH
3. Fixing some issues found
4. Not limiting number entered by user

fixes #17198, #17200
@benjthayer
Copy link

Designs for max button interaction:
https://www.figma.com/design/TS0eQX9dAZXqZtELiwKIoK/Swap?node-id=6435-84369&t=gPSVbg4pamiU7kHf-4

cc @alaibe @Khushboo-dev-cpp @anastasiyaig @Cuteivist

Khushboo-dev-cpp added a commit that referenced this issue Feb 6, 2025
@Khushboo-dev-cpp
feat(@desktop/wallet): Swap changes needed for -2.33
c4a5e34 
1. Max button functionality
2. Hardcode swap modal to swap USDT <-> WETH
3. Fixing some issues found
4. Not limiting number entered by user

fixes #17198, #17200
@Khushboo-dev-cpp Khushboo-dev-cpp moved this from In Progress to Code Review in Status Desktop/Mobile Board Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khushboo-dev-cpp Khushboo-dev-cpp

Labels
wallet-team
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

feat(@desktop/wallet): Swap changes needed for 2.33 status-im/status-desktop
3 participants
@alaibe @Khushboo-dev-cpp @benjthayer