Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onboarding] Make UI components keycard terminology consistent with Keycard API #17207

Open
igor-sirotin opened this issue Feb 4, 2025 · 0 comments
Assignees
Milestone

Comments

@igor-sirotin
Copy link
Contributor

igor-sirotin commented Feb 4, 2025

We should follow Keycard API names of the functions:

  1. Initialize(pin, puk) - to be used when you get a factory empty keycard. This way we set the PIN (and PUK).
  2. Authorize(pin) - to be used to access authorized-only API of the keycard, e.g. LoadMnemonic, SignTransaction, etc.
  3. Unblock(puk) - to be used in BlockedPIN` state, i.e. unblock the keycard with PUK.
  4. LoadMnemonic / GenerateMnemonic - no "seed phrase"/"seed words".

setPin/setPuk should not exist.

Also I think we sometimes use setPin to collect the PIN during onboarding and pass it later to finihsed signal.
I'm not sure, but probably we don't need to do this and PIN is always used right away to authorize the Keycard. But this needs to be double-checked.

Also, tst_OnboardingLayout login with keycard test should be reviewed after this. Details here: #17127 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants