You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should follow Keycard API names of the functions:
Initialize(pin, puk) - to be used when you get a factory empty keycard. This way we set the PIN (and PUK).
Authorize(pin) - to be used to access authorized-only API of the keycard, e.g. LoadMnemonic, SignTransaction, etc.
Unblock(puk) - to be used in BlockedPIN` state, i.e. unblock the keycard with PUK.
LoadMnemonic / GenerateMnemonic - no "seed phrase"/"seed words".
setPin/setPuk should not exist.
Also I think we sometimes use setPin to collect the PIN during onboarding and pass it later to finihsed signal.
I'm not sure, but probably we don't need to do this and PIN is always used right away to authorize the Keycard. But this needs to be double-checked.
Also, tst_OnboardingLayout login with keycard test should be reviewed after this. Details here: #17127 (comment)
The text was updated successfully, but these errors were encountered:
We should follow Keycard API names of the functions:
Initialize(pin, puk)
- to be used when you get a factory empty keycard. This way we set the PIN (and PUK).Authorize(pin)
- to be used to access authorized-only API of the keycard, e.g.LoadMnemonic
,SignTransaction
, etc.Unblock(puk) - to be used in
BlockedPIN` state, i.e. unblock the keycard with PUK.LoadMnemonic
/GenerateMnemonic
- no "seed phrase"/"seed words".setPin
/setPuk
should not exist.Also I think we sometimes use
setPin
to collect the PIN during onboarding and pass it later tofinihsed
signal.I'm not sure, but probably we don't need to do this and PIN is always used right away to authorize the Keycard. But this needs to be double-checked.
Also,
tst_OnboardingLayout
login with keycard test should be reviewed after this. Details here: #17127 (comment)The text was updated successfully, but these errors were encountered: