From a2aadd1454c96de68734f6cdd589604f476df667 Mon Sep 17 00:00:00 2001
From: Stephen <stephband@cruncher.ch>
Date: Mon, 14 Oct 2024 16:30:02 +0200
Subject: [PATCH] Updates to Signal.frame, dom elements()

---
 element/element.js                   |  1 +
 literal-element/modules/lifecycle.js | 24 +++++++------
 literal-html/module.js               | 53 ++++++++--------------------
 literal-html/test.html               |  2 ++
 modules/compile/compile-node.js      |  2 --
 modules/dom/get-by-id.js             |  4 +--
 modules/renderer/cue.js              |  8 ++---
 modules/renderer/renderer.js         | 18 +++++-----
 modules/template.js                  |  8 ++---
 9 files changed, 48 insertions(+), 72 deletions(-)

diff --git a/element/element.js b/element/element.js
index c1f8d83..4e3f20b 100644
--- a/element/element.js
+++ b/element/element.js
@@ -121,6 +121,7 @@ export default function LiteralElement(tag, lifecycle = {}, properties = {}) {
 
             const consts   = { host: this, shadow, internals };
             const renderer = Literal.fromFragment(name, template.content, this, consts);
+
             shadow.appendChild(renderer.content);
 
             // Call lifecycle.construct()
diff --git a/literal-element/modules/lifecycle.js b/literal-element/modules/lifecycle.js
index 1d17db0..1a86cdc 100644
--- a/literal-element/modules/lifecycle.js
+++ b/literal-element/modules/lifecycle.js
@@ -39,16 +39,18 @@ export default {
             internals.attributes.reduce(assignProperty, {}) :
             nothing ;
 
-        if (internals.src) {
-            internals.src.then((module) => {
-                // TODO: can't we just pass module as scope? Why not?
-                const scope = assign({}, module);
-                delete scope.default;
-                defineElement(internals.tag, this, module.default || {}, attributes, scope)
-            });
-        }
-        else {
-            defineElement(internals.tag, this, {}, attributes, {});
-        }
+        return [render(() => {
+            if (internals.src) {
+                internals.src.then((module) => {
+                    // TODO: can't we just pass module as scope? Why not?
+                    const scope = assign({}, module);
+                    delete scope.default;
+                    defineElement(internals.tag, this, module.default || {}, attributes, scope)
+                });
+            }
+            else {
+                defineElement(internals.tag, this, {}, attributes, {});
+            }
+        })];
     }
 }
diff --git a/literal-html/module.js b/literal-html/module.js
index 89c5da3..fd7cd52 100644
--- a/literal-html/module.js
+++ b/literal-html/module.js
@@ -16,9 +16,10 @@ library provides another template, `<template is="literal-shadow">`
 
 import Signal         from 'fn/signal.js';
 import element, { getInternals } from 'dom/element.js';
+import createObjectProperty from 'dom/element/create-object-property.js';
 import assignDataset  from '../modules/dom/assign-dataset.js';
 import requestData    from '../modules/request-data.js';
-import DOMRenderer    from '../modules/template.js';
+import Literal        from '../modules/template.js';
 import { printError } from '../modules/print.js';
 
 
@@ -29,8 +30,7 @@ export default element('<template is="literal-html">', {
     construct: function(shadow, internals) {
         internals.initialised = false;
         internals.pushed      = false;
-        internals.data        = Signal.of();
-        internals.renderer    = DOMRenderer.fromTemplate(this, this.parentElement);
+        internals.renderer    = Literal.fromTemplate(this, this.parentElement);
     },
 
     connect: function(shadow, internals) {
@@ -38,25 +38,23 @@ export default element('<template is="literal-html">', {
         if (internals.initialised) { return; }
         internals.initialised = true;
 
-        // Observe signal listens to signal value changes and calls fn()
-        // immediately if signal already has value, and on next tick after
-        // signal mutates
-        Signal.observe(internals.data, (data) => {
-            const { renderer } = internals;
+        // If src or data was not set use data found in dataset
+        if (!internals.promise && !internals.pushed) {
+            this.data = assignDataset({}, this.dataset);
+        }
+
+        // Render data from signalling properties immediately once, and then
+        // on frame following signal invalidation
+        return [Signal.frame(() => {
+            if (!this.data) return;
 
-            if (!data) return;
             const fragment = renderer.push(data);
 
-            // Replace DOM content on first push
+            // Replace DOM content on first push only
             if (internals.pushed) return;
             internals.pushed = true;
             this.replaceWith(fragment);
-        });
-
-        // If src or data was not set use data found in dataset
-        if (!internals.promise && !internals.pushed) {
-            internals.data.value = assignDataset({}, this.dataset);
-        }
+        })];
     }
 }, {
     /**
@@ -117,26 +115,5 @@ export default element('<template is="literal-html">', {
     (well, not quite immediately – literal renders changes on the next frame).
     **/
 
-    data: {
-        attribute: function(json) {
-            try {
-                this.data = JSON.parse(json);
-            }
-            catch(e) {
-                throw new Error('Invalid JSON in <template is="literal-template"> data attribute: "' + json + '"');
-            }
-        },
-
-        get: function() {
-            const internals = getInternals(this);
-            return internals.renderer ?
-                internals.renderer.data :
-                null ;
-        },
-
-        set: function(object) {
-            const internals = getInternals(this);
-            internals.data.value = object || null;
-        }
-    }
+    data: createObjectProperty()
 }, null, 'stephen.band/literal/');
diff --git a/literal-html/test.html b/literal-html/test.html
index 51356ae..355b124 100644
--- a/literal-html/test.html
+++ b/literal-html/test.html
@@ -23,9 +23,11 @@
     }</script>
 
     <link rel="stylesheet" href="../../bolt/elements/html.css" />
+    <link rel="stylesheet" href="../../bolt/elements/type.css" />
     <link rel="stylesheet" href="../../bolt/elements/table.css" />
     <link rel="stylesheet" href="../../bolt/elements/form.css" />
     <link rel="stylesheet" href="../../bolt/elements/input-range.css" />
+    <link rel="stylesheet" href="../../bolt/classes/text.css" />
     <link rel="stylesheet" href="../../bolt/classes/block.css" />
     <link rel="stylesheet" href="../../bolt/classes/button.css" />
     <link rel="stylesheet" href="../../bolt/classes/select-button.css" />
diff --git a/modules/compile/compile-node.js b/modules/compile/compile-node.js
index d55246d..e214d18 100644
--- a/modules/compile/compile-node.js
+++ b/modules/compile/compile-node.js
@@ -164,8 +164,6 @@ const compileNode = overload((targets, node) => toType(node), {
                 return targets;
             }
             catch(error) {
-console.log('COMPILE ERROR', node, printError(target, error));
-node.textContent = 'HHHEEEEELLLLPPPPP!!';
                 node.replaceWith(printError(target, error));
                 return targets;
             }
diff --git a/modules/dom/get-by-id.js b/modules/dom/get-by-id.js
index 1cc1dd8..1075622 100644
--- a/modules/dom/get-by-id.js
+++ b/modules/dom/get-by-id.js
@@ -1,7 +1,7 @@
 
 export default function getById(src) {
-    const id          = src.slice(1);
-    const template    = document.getElementById(id);
+    const id       = src.slice(1);
+    const template = document.getElementById(id);
 
     if (!template) {
         throw new Error('Template ' + src + ' not found');
diff --git a/modules/renderer/cue.js b/modules/renderer/cue.js
index 3dfcb5b..61d4d44 100644
--- a/modules/renderer/cue.js
+++ b/modules/renderer/cue.js
@@ -4,8 +4,6 @@ import Signal    from 'fn/signal.js';
 import { stats } from './renderer.js';
 
 const renderers = [];
-let cued;
-
 const render = window.DEBUG && window.DEBUG.literal !== false ? function render(t) {
     let t0 = window.performance.now() / 1000;
 
@@ -54,7 +52,6 @@ const render = window.DEBUG && window.DEBUG.literal !== false ? function render(
             '#ba4029');
     }
 
-    cued = undefined;
     renderers.length = 0;
 } : function render() {
     let n = -1;
@@ -65,7 +62,6 @@ const render = window.DEBUG && window.DEBUG.literal !== false ? function render(
         renderer.status = 'idle';
     }
 
-    cued = undefined;
     renderers.length = 0;
 } ;
 
@@ -80,10 +76,10 @@ export function cue(renderer) {
     // Create a new cued render process by promise...
     //if (!cued) cued = promise.then(render);
     // ...or by animation frame
-    if (cued === undefined) cued = requestAnimationFrame(render);
+    if (!renderers.length) requestAnimationFrame(render);
     renderers.push(renderer);
     renderer.status = 'cued';
-    return cued;
+    return renderer;
 }
 
 /**
diff --git a/modules/renderer/renderer.js b/modules/renderer/renderer.js
index 0fdea81..3cce3f5 100644
--- a/modules/renderer/renderer.js
+++ b/modules/renderer/renderer.js
@@ -1,10 +1,10 @@
 
-import { remove }        from 'fn/remove.js';
-import { ObserveSignal } from 'fn/signal.js';
-import Data              from 'fn/data.js';
-import scope             from '../scope.js';
-import { cue, uncue }    from './cue.js';
-import toText            from './to-text.js';
+import { remove }     from 'fn/remove.js';
+import { Observer }   from 'fn/signal.js';
+import Data           from 'fn/data.js';
+import scope          from '../scope.js';
+import { cue, uncue } from './cue.js';
+import toText         from './to-text.js';
 
 
 const assign     = Object.assign;
@@ -185,7 +185,7 @@ export default class Renderer {
         // signals to invalidate. It does have status.
         if (this.status === 'done' || this.status === 'cued') return;
 
-        // Stop async values being rendered
+        // Stop async values from the last evaluation from being rendered
         this.asyncs && this.asyncs.forEach(stop);
 
         // Cue evaluation on next frame
@@ -200,8 +200,8 @@ export default class Renderer {
             uncue(this);
         }
 
-        // Set this.status = 'done'
-        ObserveSignal.prototype.stop.apply(this);
+        // Set this.status = 'done', removes from signal graph
+        Observer.prototype.stop.apply(this);
 
         // Stop async values being rendered
         this.asyncs && this.asyncs.forEach(stop);
diff --git a/modules/template.js b/modules/template.js
index 9413cd0..f6c4f71 100644
--- a/modules/template.js
+++ b/modules/template.js
@@ -108,7 +108,7 @@ export default class Literal {
     Literal.compile(identifier, fragment, options)
     **/
 
-    static compile(id, fragment, options) {
+    static compile(id, fragment, options = {}) {
         if(cache[id]) return cache[id];
 
         if (window.DEBUG) {
@@ -155,9 +155,9 @@ export default class Literal {
         return Literal.fromTemplate(create('template', html), element, consts, data);
     }
 
+    #data;
     #first;
     #last;
-    #data;
 
     constructor(fragment, targets, parent = template.parentElement, consts = {}, data) {
         const children = fragment.childNodes;
@@ -290,8 +290,8 @@ export default class Literal {
 
     /**
     .remove()
-    Removes rendered content from the DOM, placing it back in the
-    `.content` fragment.
+    Removes rendered content from the DOM and places it back in the `.content`
+    fragment.
     **/
 
     remove() {