Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprectaed in c++17 out-of-line definition of constexpr static data member #1197

Closed
arturbac opened this issue Jul 22, 2024 · 1 comment · Fixed by #1488
Closed

deprectaed in c++17 out-of-line definition of constexpr static data member #1197

arturbac opened this issue Jul 22, 2024 · 1 comment · Fixed by #1488
Labels
external An external dependency issue/concern

Comments

@arturbac
Copy link
Contributor

There are plenty of deprecated out of line static constexpr declarations
You can easy get rid of them with clang and

target_compile_options(glaze_glaze INTERFACE -Werror=deprecated-redundant-constexpr-static-def)

which will produce errors

error: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated
@stephenberry
Copy link
Owner

I fixed one location of this error in #1200, however most of these occur due to https://github.com/fastfloat/fast_float, and I have raised an issue there for them to be fixed.

@stephenberry stephenberry added the external An external dependency issue/concern label Jul 22, 2024
@stephenberry stephenberry linked a pull request Dec 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external An external dependency issue/concern
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants