Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade non-existing parameter to a warning (again) #1137

Open
olofk opened this issue Jun 14, 2024 · 1 comment
Open

Downgrade non-existing parameter to a warning (again) #1137

olofk opened this issue Jun 14, 2024 · 1 comment

Comments

@olofk
Copy link

olofk commented Jun 14, 2024

0ab1ed9 made it an error to apply non-existing parameters. While there are reasons for that, I would argue for reverting this change to make it a warning instead again. There are two semi valid reasons that I can cite.

  1. Having multiple tops in a simulation, it can get a bit fiddly to filter out which parameters go to which top. The easiest way tends to be to just apply all params to all tops
  2. Running alternatively gatelevel and RTL simulations with the same setup where the gatelevel model has consumed all parameters.
@caryr
Copy link
Collaborator

caryr commented Jun 14, 2024

Both reasons can be solved by adding all the parameters to the top level/gate level modules and the error makes it obvious which parameters are missing.

I would not want to make this a warning in general, but we could possibly add an option to downgrade the error to a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants