pisr param override #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parameter override for the "Potential Incoming Solar Radiation" tool to properly define the hour range values within the function. I have tested this and can confirm that it works as intended (Windows 11, R 4.3.3, SAGA GIS 9.3.1). Observing the help files for this SAGA GIS function as far back as I can find confirms that the altered argument names are the same across all versions of SAGA GIS, specifically:
HOUR_RANGE_MIN, andHOUR_RANGE_MAXMerging this PR would allow for closing of this issue.