Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: stop storing delegations separately from invocations #210

Open
travis opened this issue Jun 26, 2023 · 0 comments
Open

proposal: stop storing delegations separately from invocations #210

travis opened this issue Jun 26, 2023 · 0 comments

Comments

@travis
Copy link
Member

travis commented Jun 26, 2023

Context

We currently store delegations in their own R2 bucket. Theoretically, all delegations should also be included in a UCAN invocation that we store as part of the UCAN invocation log, which means that we could just refer to them where they live in the invocations they were originally part of. This was partially implemented in #194.

In practice, delegations created by our access/confirm provider are not included in a UCAN invocation, which means that we cannot complete the work we started in #194 until they are.

Proposal

To finish this work, https://github.com/web3-storage/w3up/blob/main/packages/upload-api/src/access/confirm.js#L59 should be reworked to invoke an access/delegate (? - double check with Irakli) UCAN and then re-enable the FIND_DELEGATIONS_IN_INVOCATIONS feature flag (https://github.com/web3-storage/w3infra/pull/194/files#diff-1fd3717c8177f7e6c62c854a870b4d2fb040f1353302bbacc0edef9bc7bd6ffdR31)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant