Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ceph tests for Object Lock #406

Closed
amwolff opened this issue Feb 13, 2024 · 9 comments
Closed

Enable Ceph tests for Object Lock #406

amwolff opened this issue Feb 13, 2024 · 9 comments

Comments

@amwolff
Copy link
Member

amwolff commented Feb 13, 2024

Goal

This issue is to make meaningful progress on Object Lock implementation within core and edge services. Specifically, to support immutable backups in backup software products like Veeam.

What needs to be done? • Acceptance Criteria

Let's find tests in test suites that we use that can be enabled for what we already implemented.

Depends on…

At least #397.

Links

@neo-cypher
Copy link
Contributor

Ceph object lock tests enabled in gateway-st , not main, currently failing. Further review is needed.

@neo-cypher
Copy link
Contributor

Report of failing tests and review of tests enabled underway.

@storj-gerrit
Copy link

storj-gerrit bot commented Sep 5, 2024

@pwilloughby
Copy link
Contributor

We're only able to pass one addtional ceph test, test_object_lock_put_obj_retention_invalid_mode. The remaining tests are relying on setup code using put_object_lock_configuration. I think we should wait on this ticket until #501 is complete.

@ferristocrat
Copy link
Contributor

We're only able to pass one addtional ceph test, test_object_lock_put_obj_retention_invalid_mode. The remaining tests are relying on setup code using put_object_lock_configuration. I think we should wait on this ticket until #501 is complete.

bummer. but makes sense - we have initial validation from manual tests and associated integration tests...

@NiaStorj NiaStorj changed the title Enable OL tests for partial implementation of Object Lock Enable Ceph tests for Object Lock Nov 13, 2024
@ferristocrat
Copy link
Contributor

We initially used this ticket to test our early version of object lock that we used to validate Veeam compatibility. We are updating the ticket to include enabling ceph tests for our now complete version of object lock.

@NiaStorj NiaStorj assigned halkyon and unassigned pwilloughby Nov 19, 2024
@storj-gerrit
Copy link

storj-gerrit bot commented Nov 21, 2024

Change miniogw: fix legal hold not implemented on single-tenant gateway mentions this issue.

storjBuildBot pushed a commit to storj/gateway-st that referenced this issue Nov 21, 2024
Updates storj/edge#406

Change-Id: Id1e56042abcf7c4155e7de5d2b286ff11113f55b
@storj-gerrit
Copy link

storj-gerrit bot commented Nov 21, 2024

Change testsuite/ceph-s3-tests: re-enable more object lock tests mentions this issue.

@halkyon
Copy link
Contributor

halkyon commented Nov 22, 2024

https://review.dev.storj.io/c/storj/gateway/+/15402 enables the rest of the object lock tests. I created a few new issues from the tests that are still failing:

These don't appear to be major problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants