loadStoryblokBridge does not properly resolve or reject

[addemod]

Describe the issue you're facing

When calling loadStoryblokBridge (loadBridge), the promise won't resolve or reject properly in certain cases.
Instead of calling return;, the promise should be resolved or rejected, based on the reason of returning early.

In the first case, if window is undefined, reject() should be called with an error. The second case, where the script tag already exists, the promise should just be resolved by calling resolve().

Should reject:

storyblok-js/src/bridge.ts

Line 7 in 940cf3c

return;

Should resolve:

storyblok-js/src/bridge.ts

Line 24 in 940cf3c

return;

Reproduction

https://stackblitz.com/edit/js-gn3awrkt?file=index.js

Steps to reproduce

Check the Stackblitz app. The console logs will never be outputted, after loading the script. The reason for this, in the reproduction, is because the script tag already exists in index.html, which could be a real case.

If any condition in loadBridge forces a return; call, the promise will never resolve.

System Info

System:
    OS: Windows 11 10.0.26100
    CPU: (22) x64 Intel(R) Core(TM) Ultra 7 155H
    Memory: 8.22 GB / 31.46 GB
  Binaries:
    Node: 20.18.1 - C:\nvm4w\nodejs\node.EXE
    Yarn: 1.22.22 - C:\nvm4w\nodejs\yarn.CMD
    npm: 10.8.2 - C:\nvm4w\nodejs\npm.CMD
    pnpm: 9.15.3 - C:\nvm4w\nodejs\pnpm.CMD
  Browsers:
    Edge: Chromium (131.0.2903.146)

Used Package Manager

pnpm

Error logs (Optional)

No response

Validations

• Follow our Code of Conduct

[edodusi]

Thanks @addemod for reporting this, we will investigate on a fix