-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Support bun as a package manager #28164
Comments
Any kind of help would be appreciated and I can give guidance and support if necessary! |
Thanks for pointing out the way! Will have a look at it tonight! |
If I can help in some way, let me know! |
My first findings: My fork: https://github.com/storybookjs/storybook/compare/next...rhuanbarreto:storybook:next?expand=1 Bun doesn't support many json outputs for detecting package versions. Need to work more on this. |
I don't now how, because i tried to use storybook myself into a nextjs bun boilerplate, but midday is staring to use storybook in their turborepo with bun and biome. I hope it helps some kind. |
@rhuanbarreto Does it make sense to ignore this limitation for now and just continue on the parts which bun supports? Maybe we can find alternative approaches to read a package version for example. |
@valentinpalkovic I'm trying to follow the interface Storybook gives me in order to do the parsing. For all other package managers, there's a json output where you can parse the values. The supported plain text output rather than the binary format is a yarn v1 plain text that needs it's own parser. I'm not saying it's not possible. But for working as a package manager, this part of parsing the lockfile is an issue that increases the complexity. Just need effort to make it work. Once bun itself in the near future will support a more parseable output (hence the linked issue here), I don't think it's worth the effort (for me) to make it work until this change. |
One more thing. Bun still doesn't support many of the commands that the other package managers have in order to peek into the dependency tree. Is this a blocker? No. But increases the level of complexity by some orders of magnitude. I think Bun also need to help introducing more package manager commands into their own software so this can be solved easily. |
In the meantime, I think we could rely on |
I only hope to use storybook under the project managed by the bun. |
@valentinpalkovic @rhuanbarreto I went ahead and created a PR that would demonstrate what i meant on the previous comment. |
I love to be able to use bun with storybook, so if this could be fixed for the next release I would be so grateful ❤️ |
Hi team, any update on this? |
angular NX storybook projects are affected as well is storybook failing or can we ignore this log message
|
|
@valentinpalkovic Is this still open? |
Describe the bug
Storybook supports npm, pnpm and yarn berry as package managers during installation, automigration, upgrade and startup. Adding support for Bun's package manager would be great since it allows a wide range of users to initialize, upgrade and automigrate Storybook in repositories using Bun as the package manager.
Tasks
Acceptance criteria
When Bun is used as a package manager, it should be possible to
Additional context
No response
The text was updated successfully, but these errors were encountered: