Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook composition from refs seems to require adding undocumented id parameter #30628

Open
pekkast opened this issue Feb 22, 2025 · 2 comments

Comments

@pekkast
Copy link

pekkast commented Feb 22, 2025

When using refs for composition https://storybook.js.org/docs/sharing/storybook-composition

  refs: {
    UI5: {
      // @ts-expect-error
      id: 'UI5',
      title: 'UI5 Web Components',
      url: 'https://sap.github.io/ui5-webcomponents-react/v2',
      expanded: false,
      sourceUrl: 'https://github.com/sap/ui5-webcomponents-react',
    },
  },

I'm forced to give that additional parameter id to get this working. Also param sourceUrl is not in ts definitions, but works in final output.

await api.setRef(id!, {

Also the ref is duplicated (shows up twice) in the storybook ui.

@valentinpalkovic
Copy link
Contributor

Hi @pekkast,

Thank you for reporting.

Please provide some additional information:

  • Affected Storybook version of the root Storybook and the composite Storybook

@pekkast
Copy link
Author

pekkast commented Feb 24, 2025

Hello, thanks for reply. Both seem to have version 8.5.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants