-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename QTCBS to QTB11 #235
Comments
Yes it does also exist for QTCC. As I said, if this really is an issue, please feel free to refactor and also refactor strands_hri as this is using it heavily. I have no time to do this so please don't break my code just because of a naming convention. |
@PDuckworth you are right, but as this is mostly a documentation issue rather than a code issue, I suggest to simply update the documentation and point out the equivalence there. |
Or, alternatively introduce aliases in QSRlib to avoid breaking existing code. |
@marc-hanheide Not sure what you mean by aliases, but if you are referring to dictionary mapping it might be tricky as this name is unique and tightly integrated to the retrieval and parsing of the QSRs returned also. @cdondrup Don't worry about breaking code. Will not actually refactor but do one of the following solutions I see viable and quick:
@PDuckworth @cdondrup What about QTCCS and QTCBCS? To what should they be renamed? |
The versions used are QTCB11, QTCC21, and then these are combined into QTCBC which would then be QTCB11C21 to be exact but I defined that as QTCBC in my paper. It's up to you how you want to name them. |
As per here or here, QTCBS is already defined as QTCB11.
Similar issue may exist with QTCC also. @yianni @cdondrup
The text was updated successfully, but these errors were encountered: