Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member Export outputs duplicates when using pmpro_set_max_user_per_export_loop filter #3291

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Member Export outputs duplicates when using pmpro_set_max_user_per_export_loop filter #3291

wants to merge 1 commit into from

Conversation

MaximilianoRicoTabo
Copy link
Contributor

@MaximilianoRicoTabo MaximilianoRicoTabo commented Feb 11, 2025 •
edited
Loading

  • Ensure the filter doesn't lead to a fatal error by ensuring the returned value is valid or set the default
  • Fix array_slice start and end params to calculations.

### ERROR SCREENSHOT

image

### FIXED SCREENSHOTS

image image image image

All Submissions:

Changes proposed in this Pull Request:

Added intval to the filter result of $max_users_per_loop and set the default if it's 0. Any non integer value or 0 would through a fatal error.

Also, better calculate iteration start and end to avoid duplicates while iterate.

Resolves #3236 .

How to test the changes in this Pull Request:

Follow steps described in #3236

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@MaximilianoRicoTabo
Member Export outputs duplicates when using pmpro_set_max_user_per_ex…
f71bfa0 
…port_loop filter

 * Ensure the filter doesn't lead to a fatal error by ensuring the returned value is valid or set the default
 * Fix array_slice start and end params to calculations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Member Export outputs duplicates when using pmpro_set_max_user_per_export_loop filter
1 participant
@MaximilianoRicoTabo