Accept custom min and step attributes for Number field type. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
I've been running into this bug lately and only just now managed to track down what was going on. This PR looks good to merge, though I think the code could be simplified a bit.
@kimcoleman Could this be merged soon?
Comment on lines
+396
to
+411
| if ( ! empty( $this->html_attributes ) ) { | ||
| // If custom values not available set the defaults | ||
| if ( ! array_key_exists( 'min', $this->html_attributes ) ) { | ||
| $this->html_attributes['min'] = '0'; | ||
| } | ||
| if ( ! array_key_exists( 'step', $this->html_attributes ) ) { | ||
| $this->html_attributes['step'] = '1'; | ||
| } | ||
| $r .= $this->getHTMLAttributes(); | ||
| $r .= ' />'; | ||
| } else { | ||
| // Set the defaults | ||
| $this->html_attributes['min'] = '0'; | ||
| $this->html_attributes['step'] = '1'; | ||
| $r .= $this->getHTMLAttributes(); | ||
| } | ||
| $r .= ' />'; |
There was a problem hiding this comment.
This could be simplified:
if ( empty( $this->html_attributes ) ) {
$this->html_attributes = array();
}
// If no custom min/step is set, use defaults.
if ( ! array_key_exists( 'min', $this->html_attributes ) ) {
$this->html_attributes['min'] = 0;
}
if ( ! array_key_exists( 'step', $this->html_attributes ) ) {
$this->html_attributes['step'] = 1;
}
$r .= $this->getHTMLAttributes();
$r .= ' />';
There was a problem hiding this comment.
Thanks! Merging this version into core PMPro.
|
Merged into PMPro core here: strangerstudios/paid-memberships-pro@babf81e Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Remove the hardcoded default
minandstepattributes set and add them ashtml_attributes.Resolves #227
How to test the changes in this Pull Request:
minandstepto thehtml_attributesoption.Other information:
Changelog entry
BUGFIX/ENHANCEMENT: Accept custom "step" and "min" HTML attributes set in the "html_attributes" option.